Stop Links in Posts

[glennrocksvb]

Still cannot reproduce the issue using the same options you are using.

Steps 3.1 to 3.6 are not required for vB 5.5.4.

[elektro-kot]

Ok, so I understood the instructions correctly.

Could this happen due to language settings? I use Russian.

[glennrocksvb]

I can't say without looking into it and testing it.

[elektro-kot]

I can't say without looking into it and testing it.

OK. Could you take a look at the language pack, please?

[glennrocksvb]

I can't tell by just looking at the language pack. I'd have to look at the plugin code on the server and debug it to see at which point of the code the functionality breaks.

[elektro-kot]

Hi Glenn.
Understand thanks.
There seems to be a problem with PHP
I checked: on my server with PHP 7.3.9 there is a problem, on the test server with PHP 7.1 mod works fine

[glennrocksvb]

Can you check the server logs for any PHP errors? Also try enabling debug mode to see if any PHP error appears on the page.

[elektro-kot]

Yes, I will try and let you know the results later. Thank you

[elektro-kot]

Still cannot reproduce the issue

Sorry, Glenn, I described the issue incorrectly.
Language packs and PHP are not relevant to this issue.

Now I understand and, I think, the problem is not with the mod, this is a problem with the advanced editor of vBulletin.

If I manually specify BBcode, the module disable the link, but if I writed the link, then selected it and in the advanced editor clicked the BBcode icons - bold text, url ... etc, then the link is skipped.

Please let me know if you see this problem.

Stops link



Skips link

[glennrocksvb]

Thanks for providing more details. I will try it when I get home.

[elektro-kot]

Thank you Glenn, I'm looking forward to your reply.

[kether]

Did this mod ever get sorted to work correctly?

Thanks,
Kether

[kether]

Did this mod ever get sorted to work correctly?

Thanks,
Kether

Hi everyone. I'm really interested in this mod, but do not want to buy something that isn't working. Any updates? Does this work with VB 5.6.0?

cheers,
Kether

[ayjayef]

I hate "me too" replies on my forum but I agree with Kether, stopping links would be great but only if it works well. (I'm using VB 5.6.0 too)
Last update by @glennrocksvb this thread was 10 months ago.

[elektro-kot]

kether , ayjayef

Hi.
The first version of the module worked fine, there was one error (previously i reported a problem).

Recently, Glenn has released an update (version 1.1), everything works perfect now.

[ayjayef]

I just posted a test from low post count account above with a link in it and it has correctly hid the post in a moderation queue.

...but, it emailed the subscription notification with the hidden spam link in it to everyone who is subscribed to this thread.

Bug?

[glennrocksvb]

I just posted a test from low post count account above with a link in it and it has correctly hid the post in a moderation queue.

...but, it emailed the subscription notification with the hidden spam link in it to everyone who is subscribed to this thread.

Bug?

That's a good catch. That looks like a bug. But even without this mod vB should not have emailed subscription notifications in the first place if a post is in moderated queue, right? That seems like a vB bug in itself. Other users should not see the moderated posts in the email.

[ayjayef]

I'm not smart enough to know if it's vB or your addon but I'm sure you'll make sense of it.

I've not seen it happen on my site though.

[glennrocksvb]

I'll test on my local setup to check if the issue also occurs there.

[ayjayef]

I bought the mod, simple install into vBull 5.6.6 and the mod works well on all our testing including the spammers sneaky color changed links, thanks!

I can confirm that if someone is subscribed to the thread or the sub-forum they will get email notification of a new post showing the moderated content which is not ideal. Hopefully we can workout how to stop that.

[ayjayef]

Good question, on my site the subscriber was an admin but on your site (this thread) I'm not an admin and it did the same.

[glennrocksvb]

Can you test with a regular user subscriber on your site?

[ayjayef]

Just created a new user and can confirm they received email notification with the the message and it appears in their message centre too... both with the link in a post that is waiting for moderation.

[glennrocksvb]

Now can you temporarily disable this mod and then try again? Just want to confirm it works without the mod.

[ayjayef]

Not really, if I disable the mod then the post won't be auto-moderated and the 2nd user would get an email anyway.

[ayjayef]

This bug became real today. Stop Links in Posts blocked a spammer (great!) put the message in a moderation queue and emailed all those subscribed to the area. One of our users followed the forum link in his email notification and got and error that he wasn't allowed to view (as expected as it's in the moderation queue). Contacted us to ask why he was blocked!

[glennrocksvb]

Ok I think I know what's going on now. The PHP hook that is used to set the reported post into moderation queue that the mod is doing is vB's onAfterContentAddOrUpdate hook function which means the spam post has been saved already before vB triggered this hook. So at that point, vB has triggered the email notifications to the subscribers (as it normally does for a new post) before the mod is able to automatically disapprove the post.

To resolve this issue, vB should add a PHP hook right before it triggers the email to the subscribers to let third-party mods be able to cancel the email.

I will see if I can manually add a PHP hook as a temporary solution. If this is feasible, this would require editing existing PHP code which means this would have to be re-applied after every vB upgrade.

[ayjayef]

My experience of vB development is that they'll never do something to help a third party mod which wouldn't be news to you either.

Re applying a code fudge after future upgrades is a pain to remember but at worst, it ends up like it is at the moment until I see the problem and patch again so that's not too bad a result.

[glennrocksvb]

I think I found a solution that doesn't require a new PHP hook or editing existing PHP code. I just need to test it thoroughly.

[glennrocksvb]

If you want ayjayef I can send you the updated file that is part of the mod to quickly test the solution on your site. What do you think?

[glennrocksvb]

ayjayef, I have deployed the fix here on this site. Can you test using your other account?

[ayjayef]

That works on this site. Spamtester posted a link in reply to this post and it's in the moderation queue. ayjayef didn't get email notification of a new post.
I think you've fixed the quirk.