Stop Links in Posts

[glennrocksvb]

Still cannot reproduce the issue using the same options you are using.

Steps 3.1 to 3.6 are not required for vB 5.5.4.

[elektro-kot]

I can't say without looking into it and testing it.

OK. Could you take a look at the language pack, please?

[elektro-kot]

Still cannot reproduce the issue

Sorry, Glenn, I described the issue incorrectly.
Language packs and PHP are not relevant to this issue.

Now I understand and, I think, the problem is not with the mod, this is a problem with the advanced editor of vBulletin.

If I manually specify BBcode, the module disable the link, but if I writed the link, then selected it and in the advanced editor clicked the BBcode icons - bold text, url ... etc, then the link is skipped.

Please let me know if you see this problem.

Stops link



Skips link

[kether]

Did this mod ever get sorted to work correctly?

Thanks,
Kether

[kether]

Did this mod ever get sorted to work correctly?

Thanks,
Kether

Hi everyone. I'm really interested in this mod, but do not want to buy something that isn't working. Any updates? Does this work with VB 5.6.0?

cheers,
Kether

[ayjayef]

I hate "me too" replies on my forum but I agree with Kether, stopping links would be great but only if it works well. (I'm using VB 5.6.0 too)
Last update by @glennrocksvb this thread was 10 months ago.

[elektro-kot]

kether , ayjayef

Hi.
The first version of the module worked fine, there was one error (previously i reported a problem).

Recently, Glenn has released an update (version 1.1), everything works perfect now.

[ayjayef]

I just posted a test from low post count account above with a link in it and it has correctly hid the post in a moderation queue.

...but, it emailed the subscription notification with the hidden spam link in it to everyone who is subscribed to this thread.

Bug?

[glennrocksvb]

I just posted a test from low post count account above with a link in it and it has correctly hid the post in a moderation queue.

...but, it emailed the subscription notification with the hidden spam link in it to everyone who is subscribed to this thread.

Bug?

That's a good catch. That looks like a bug. But even without this mod vB should not have emailed subscription notifications in the first place if a post is in moderated queue, right? That seems like a vB bug in itself. Other users should not see the moderated posts in the email.

[ayjayef]

I'm not smart enough to know if it's vB or your addon but I'm sure you'll make sense of it.

I've not seen it happen on my site though.

[ayjayef]

I bought the mod, simple install into vBull 5.6.6 and the mod works well on all our testing including the spammers sneaky color changed links, thanks!

I can confirm that if someone is subscribed to the thread or the sub-forum they will get email notification of a new post showing the moderated content which is not ideal. Hopefully we can workout how to stop that.

[ayjayef]

This bug became real today. Stop Links in Posts blocked a spammer (great!) put the message in a moderation queue and emailed all those subscribed to the area. One of our users followed the forum link in his email notification and got and error that he wasn't allowed to view (as expected as it's in the moderation queue). Contacted us to ask why he was blocked!

[glennrocksvb]

Ok I think I know what's going on now. The PHP hook that is used to set the reported post into moderation queue that the mod is doing is vB's onAfterContentAddOrUpdate hook function which means the spam post has been saved already before vB triggered this hook. So at that point, vB has triggered the email notifications to the subscribers (as it normally does for a new post) before the mod is able to automatically disapprove the post.

To resolve this issue, vB should add a PHP hook right before it triggers the email to the subscribers to let third-party mods be able to cancel the email.

I will see if I can manually add a PHP hook as a temporary solution. If this is feasible, this would require editing existing PHP code which means this would have to be re-applied after every vB upgrade.

[glennrocksvb]

I think I found a solution that doesn't require a new PHP hook or editing existing PHP code. I just need to test it thoroughly.

[glennrocksvb]

ayjayef, I have deployed the fix here on this site. Can you test using your other account?