Announcement

Collapse
No announcement yet.

Stop Links in Posts

Collapse
X
Collapse
First Prev Next Last
 
  • Filter
  • Time
  • Show
Clear All
new posts

    #31
    Originally posted by ayjayef View Post
    That works on this site. Spamtester posted a link in reply to this post and it's in the moderation queue. ayjayef didn't get email notification of a new post.
    I think you've fixed the quirk.
    Awesome! I will release the fix shortly.
    Helpful? Donate. Thanks!
    Buy me a coffeePayPal QR Code
    Fast VPS Host for vBulletin:
    A2 Hosting & IONOS

    Comment


      #32
      I have released v1.2 and updated first post. All the purchasers of this mod were emailed containing the download link to the new version. Thanks to ayjayef for reporting this issue. This was a good catch.
      Helpful? Donate. Thanks!
      Buy me a coffeePayPal QR Code
      Fast VPS Host for vBulletin:
      A2 Hosting & IONOS

      Comment


      #33
      I was just emailed the new version 1.2, installed, tested, FIXED.

      Great and super speedy work Glenn, thanks!

      Comment


      • glennrocksvb
        glennrocksvb commented
        Editing a comment
        Thanks for confirming the fix works on your site.

      #34
      Found a loophole Glenn (actually spammers on our site found a loophole)
      You can put a link in a comment and it's published.

      See post #35 above.

      Comment


      • glennrocksvb
        glennrocksvb commented
        Editing a comment
        I'll take a look.

      • glennrocksvb
        glennrocksvb commented
        Editing a comment
        Maybe vB is not invoking the PHP hook in comments.
        Last edited by glennrocksvb; 01-29-2022, 11:20 PM.

      #35
      Originally posted by ayjayef View Post
      Found a loophole Glenn (actually spammers on our site found a loophole)
      You can put a link in a comment and it's published.

      See post #35 above.
      I found the issue. There are no PHP hooks when posting a comment. This is a bug on vB. I will create a bug ticket to them. I will create a temporary workaround while waiting for the official fix but it will require manually editing an existing PHP file. This means this needs to be re-applied after every vB upgrade. This is unavoidable since vB forgot to add the PHP hooks to the comments.

      This is one of those ¯\_(ツ)_/¯ moments.
      Helpful? Donate. Thanks!
      Buy me a coffeePayPal QR Code
      Fast VPS Host for vBulletin:
      A2 Hosting & IONOS

      Comment


        #36
        Originally posted by glennrocksvb View Post
        I will create a bug ticket to them.
        Bug ticket created. Please vote for it.

        https://tracker.vbulletin.com/vbulle...sues/VBV-21050

        Helpful? Donate. Thanks!
        Buy me a coffeePayPal QR Code
        Fast VPS Host for vBulletin:
        A2 Hosting & IONOS

        Comment


        • ayjayef
          ayjayef commented
          Editing a comment
          +1 vote added. Thanks Glenn.

        • Mitch
          Mitch commented
          Editing a comment
          Voted

        • glennrocksvb
          glennrocksvb commented
          Editing a comment
          Thanks for the votes!

        #37
        Voted as well.
        The Linux Community has given me much. I do what I can to return the favor!

        Comment


        • glennrocksvb
          glennrocksvb commented
          Editing a comment
          Thanks for the vote!

        #38
        Originally posted by glennrocksvb View Post
        I will create a temporary workaround while waiting for the official fix
        ayjayef, I have developed a workaround and installed it here. Can you please try it by posting a comment here using your test account?
        Helpful? Donate. Thanks!
        Buy me a coffeePayPal QR Code
        Fast VPS Host for vBulletin:
        A2 Hosting & IONOS

        Comment


          #39
          Spamtester has posted a comment with a link, it was moderated (good) and a thread subscriber ayjayef didn't get a notification (great).
          I think your patch is working well.

          Comment


          • glennrocksvb
            glennrocksvb commented
            Editing a comment
            Thanks for testing. I will release the fix shortly.

          #40
          v1.3 released and first post updated. Customers who have purchased this mod have been notified of this new version in the email.
          Helpful? Donate. Thanks!
          Buy me a coffeePayPal QR Code
          Fast VPS Host for vBulletin:
          A2 Hosting & IONOS

          Comment


          • ayjayef
            ayjayef commented
            Editing a comment
            Notified, installed and tested as working very well.
            Was a little nervous editing ajax.php but as long as it's backed-up first it's not too spooky.
            Thanks for patching the vB bug till they do (hopefully in the next release)

          • glennrocksvb
            glennrocksvb commented
            Editing a comment
            Thanks for confirming the fix works on your site.

          #41
          Not sure if it's vB quirk too but the link to the post in the Moderation queue takes you to the first post in the thread, not the offending comment message.

          [View Post] [Approve] [Delete] buttons all work fine though so it's not a "show stopper"

          Comment


            #42
            I think it's a vB quirk. The mod does not have anything to do with generating the link to the post/comment in moderation queue. Was the comment in page 2 or more? You can confirm this quirk by manually disapproving a comment if it behaves the same.
            Helpful? Donate. Thanks!
            Buy me a coffeePayPal QR Code
            Fast VPS Host for vBulletin:
            A2 Hosting & IONOS

            Comment


            • ayjayef
              ayjayef commented
              Editing a comment
              Thanks for the testing suggestion. Page 2 or more isn't a problem, seems vB will do this for any comment link while post links work fine. Another vB bug it seems.

            • glennrocksvb
              glennrocksvb commented
              Editing a comment
              I confirmed the same issue on this site. vB is linking the first post for moderated comments. This is a vB bug.

            #43
            Originally posted by glennrocksvb View Post
            Bug ticket created. Please vote for it.

            https://tracker.vbulletin.com/vbulle...sues/VBV-21050
            Thanks for your votes! This bug has been worked on and is now being code reviewed at the moment. It will not be included in the upcoming vB 5.6.7 though, based from this list of fixed tickets that made it to 5.6.7. It will probably be in 5.6.8.
            Last edited by glennrocksvb; 02-24-2022, 06:51 PM.
            Helpful? Donate. Thanks!
            Buy me a coffeePayPal QR Code
            Fast VPS Host for vBulletin:
            A2 Hosting & IONOS

            Comment


              #44
              Originally posted by glennrocksvb View Post
              Thanks for your votes! This bug has been worked on and is now being code reviewed at the moment. It will not be included in the upcoming vB 5.6.7 though, based from this list of fixed tickets that made it to 5.6.7. It will probably be in 5.6.8.
              ayjayef and others, I can confirm that this bug is now fixed in the recent vB release 5.6.8. It is specified in the bug ticket and also in the 5.6.8 release notes.

              https://forum.vbulletin.com/forum/vb...e-for-download

              If you upgrade to vB 5.6.8, the manual edit you did for v1.3 of this mod is no longer needed. When you upgrade vB, the edited PHP file will be overwritten so there's nothing to do on your end for this mod to work. Please test this mod after upgrading to vB 5.6.8 and let me know if posting links in a comment will be detected by this mod.
              Helpful? Donate. Thanks!
              Buy me a coffeePayPal QR Code
              Fast VPS Host for vBulletin:
              A2 Hosting & IONOS

              Comment


                #45
                I found an issue on their bug fix for posting comments in https://tracker.vbulletin.com/vbulle...sues/VBV-21050. I informed them about it but unfortunately it didn't make it to the final 5.6.8 release. The effect of this is even if posting comment is successful, it will always report to all third-party plugins that it failed.

                They created a new bug ticket to address this issue https://tracker.vbulletin.com/vbulle...sues/VBV-21193 and hopefully they'll include it in the next release 5.6.9 or 5.7 (whatever the next version is)

                Due to this, I have no choice but to make a workaround fix on this mod to make it compatible with 5.6.8. Watch out for this.
                Helpful? Donate. Thanks!
                Buy me a coffeePayPal QR Code
                Fast VPS Host for vBulletin:
                A2 Hosting & IONOS

                Comment


                • ayjayef
                  ayjayef commented
                  Editing a comment
                  Yes, I can confirm that vB5.6.8 still allows links in comments

                • glennrocksvb
                  glennrocksvb commented
                  Editing a comment
                  I will send you a new update (v1.4) of the mod with the workaround so you can test before I release it to all customers.

                • glennrocksvb
                  glennrocksvb commented
                  Editing a comment
                  PM sent.

                • ayjayef
                  ayjayef commented
                  Editing a comment
                  I installed the update and it didn't stop links in comments (still stops links in replies though).

              Latest Topics

              Collapse

              Working...
              X