Stop Links in Posts

[glennrocksvb]

That works on this site. Spamtester posted a link in reply to this post and it's in the moderation queue. ayjayef didn't get email notification of a new post.
I think you've fixed the quirk.

Awesome! I will release the fix shortly.

[glennrocksvb]

I have released v1.2 and updated first post. All the purchasers of this mod were emailed containing the download link to the new version. Thanks to ayjayef for reporting this issue. This was a good catch.

[ayjayef]

I was just emailed the new version 1.2, installed, tested, FIXED.

Great and super speedy work Glenn, thanks!

[ayjayef]

Found a loophole Glenn (actually spammers on our site found a loophole)
You can put a link in a comment and it's published.

See post #35 above.

[glennrocksvb]

Found a loophole Glenn (actually spammers on our site found a loophole)
You can put a link in a comment and it's published.

See post #35 above.

I found the issue. There are no PHP hooks when posting a comment. This is a bug on vB. I will create a bug ticket to them. I will create a temporary workaround while waiting for the official fix but it will require manually editing an existing PHP file. This means this needs to be re-applied after every vB upgrade. This is unavoidable since vB forgot to add the PHP hooks to the comments.

This is one of those ¯\_(ツ)_/¯ moments.

[glennrocksvb]

I will create a bug ticket to them.

Bug ticket created. Please vote for it.

https://tracker.vbulletin.com/vbulletin5/issues/VBV-21050

[Snowhog]

Voted as well.

[glennrocksvb]

I will create a temporary workaround while waiting for the official fix

ayjayef, I have developed a workaround and installed it here. Can you please try it by posting a comment here using your test account?

[ayjayef]

Spamtester has posted a comment with a link, it was moderated (good) and a thread subscriber ayjayef didn't get a notification (great).
I think your patch is working well.

[glennrocksvb]

v1.3 released and first post updated. Customers who have purchased this mod have been notified of this new version in the email.

[ayjayef]

Not sure if it's vB quirk too but the link to the post in the Moderation queue takes you to the first post in the thread, not the offending comment message.

[View Post] [Approve] [Delete] buttons all work fine though so it's not a "show stopper"

[glennrocksvb]

I think it's a vB quirk. The mod does not have anything to do with generating the link to the post/comment in moderation queue. Was the comment in page 2 or more? You can confirm this quirk by manually disapproving a comment if it behaves the same.

[glennrocksvb]

Bug ticket created. Please vote for it.

https://tracker.vbulletin.com/vbulle...sues/VBV-21050

Thanks for your votes! This bug has been worked on and is now being code reviewed at the moment. It will not be included in the upcoming vB 5.6.7 though, based from this list of fixed tickets that made it to 5.6.7. It will probably be in 5.6.8.

[glennrocksvb]

Thanks for your votes! This bug has been worked on and is now being code reviewed at the moment. It will not be included in the upcoming vB 5.6.7 though, based from this list of fixed tickets that made it to 5.6.7. It will probably be in 5.6.8.

ayjayef and others, I can confirm that this bug is now fixed in the recent vB release 5.6.8. It is specified in the bug ticket and also in the 5.6.8 release notes.

https://forum.vbulletin.com/forum/vbulletin-announcements/vbulletin-announcements_aa/4469970-vbulletin-connect-5-6-8-release-candidate-1-is-available-for-download

If you upgrade to vB 5.6.8, the manual edit you did for v1.3 of this mod is no longer needed. When you upgrade vB, the edited PHP file will be overwritten so there's nothing to do on your end for this mod to work. Please test this mod after upgrading to vB 5.6.8 and let me know if posting links in a comment will be detected by this mod.

[glennrocksvb]

I found an issue on their bug fix for posting comments in https://tracker.vbulletin.com/vbulle...sues/VBV-21050. I informed them about it but unfortunately it didn't make it to the final 5.6.8 release. The effect of this is even if posting comment is successful, it will always report to all third-party plugins that it failed.

They created a new bug ticket to address this issue https://tracker.vbulletin.com/vbulle...sues/VBV-21193 and hopefully they'll include it in the next release 5.6.9 or 5.7 (whatever the next version is)

Due to this, I have no choice but to make a workaround fix on this mod to make it compatible with 5.6.8. Watch out for this.