Stop Links in Posts

[Snowhog]

Good catch. That's a typo

Thank you. I expected as much. There are actually 15 occurrences of 1.3 within that file. For esthetics (and for the version reporting in in Manage Products), I'll correct the versioning in the file and re-install.

[glennrocksvb]

Good catch. That's a typo but it shouldn't affect the functionality. There were no actual changes in the XML in 1.4. The only changes were in hooks.php in the upload folder.

[Snowhog]

v1.4

Would you check the product_stoplinksinposts.xml file, specifically line 5. The downloaded file I got in June (v1.4) indicates it's version 1.3 (<version>1.3</version>).

[glennrocksvb]

For those following this thread, the latest patch that Glenn got me to test works well. Stops links in posts and comments in vB5.6.8

v1.4 released! Please see updated first post. And for those who've purchased this mod, please keep an eye out for the email containing the download link.

[ayjayef]

Due to this, I have no choice but to make a workaround fix on this mod to make it compatible with 5.6.8. Watch out for this.

For those following this thread, the latest patch that Glenn got me to test works well. Stops links in posts and comments in vB5.6.8

Keep an eye out for the official release.

[ayjayef]

I installed the update and it didn't stop links in comments (still stops links in replies though).

[glennrocksvb]

PM sent.

[glennrocksvb]

I will send you a new update (v1.4) of the mod with the workaround so you can test before I release it to all customers.

[ayjayef]

Yes, I can confirm that vB5.6.8 still allows links in comments

[ayjayef]

...link to the post in the Moderation queue takes you to the first post in the thread, not the offending comment message.

FYI - I can confirm that this has been fixed in vB5.6.8 and now the email notification and the message centre link take you to the offending comment, not to the first post in the thread.

[glennrocksvb]

I found an issue on their bug fix for posting comments in https://tracker.vbulletin.com/vbulle...sues/VBV-21050. I informed them about it but unfortunately it didn't make it to the final 5.6.8 release. The effect of this is even if posting comment is successful, it will always report to all third-party plugins that it failed.

They created a new bug ticket to address this issue https://tracker.vbulletin.com/vbulle...sues/VBV-21193 and hopefully they'll include it in the next release 5.6.9 or 5.7 (whatever the next version is)

Due to this, I have no choice but to make a workaround fix on this mod to make it compatible with 5.6.8. Watch out for this.

[glennrocksvb]

Thanks for your votes! This bug has been worked on and is now being code reviewed at the moment. It will not be included in the upcoming vB 5.6.7 though, based from this list of fixed tickets that made it to 5.6.7. It will probably be in 5.6.8.

ayjayef and others, I can confirm that this bug is now fixed in the recent vB release 5.6.8. It is specified in the bug ticket and also in the 5.6.8 release notes.

https://forum.vbulletin.com/forum/vbulletin-announcements/vbulletin-announcements_aa/4469970-vbulletin-connect-5-6-8-release-candidate-1-is-available-for-download

If you upgrade to vB 5.6.8, the manual edit you did for v1.3 of this mod is no longer needed. When you upgrade vB, the edited PHP file will be overwritten so there's nothing to do on your end for this mod to work. Please test this mod after upgrading to vB 5.6.8 and let me know if posting links in a comment will be detected by this mod.

[glennrocksvb]

Bug ticket created. Please vote for it.

https://tracker.vbulletin.com/vbulle...sues/VBV-21050

Thanks for your votes! This bug has been worked on and is now being code reviewed at the moment. It will not be included in the upcoming vB 5.6.7 though, based from this list of fixed tickets that made it to 5.6.7. It will probably be in 5.6.8.

[glennrocksvb]

I confirmed the same issue on this site. vB is linking the first post for moderated comments. This is a vB bug.

[ayjayef]

Thanks for the testing suggestion. Page 2 or more isn't a problem, seems vB will do this for any comment link while post links work fine. Another vB bug it seems.