Stop Links in Posts

[glennrocksvb]

Maybe vB is not invoking the PHP hook in comments.

[glennrocksvb]

I'll take a look.

[ayjayef]

Found a loophole Glenn (actually spammers on our site found a loophole)
You can put a link in a comment and it's published.

See post #35 above.

[SpamTester]

On our site links in comments are sneaking through

https://spam.com

[glennrocksvb]

Thanks for confirming the fix works on your site.

[ayjayef]

I was just emailed the new version 1.2, installed, tested, FIXED.

Great and super speedy work Glenn, thanks!

[glennrocksvb]

I have released v1.2 and updated first post. All the purchasers of this mod were emailed containing the download link to the new version. Thanks to ayjayef for reporting this issue. This was a good catch.

[glennrocksvb]

That works on this site. Spamtester posted a link in reply to this post and it's in the moderation queue. ayjayef didn't get email notification of a new post.
I think you've fixed the quirk.

Awesome! I will release the fix shortly.

[ayjayef]

That works on this site. Spamtester posted a link in reply to this post and it's in the moderation queue. ayjayef didn't get email notification of a new post.
I think you've fixed the quirk.

[glennrocksvb]

ayjayef, I have deployed the fix here on this site. Can you test using your other account?

[glennrocksvb]

If you want ayjayef I can send you the updated file that is part of the mod to quickly test the solution on your site. What do you think?

[glennrocksvb]

I think I found a solution that doesn't require a new PHP hook or editing existing PHP code. I just need to test it thoroughly.

[ayjayef]

My experience of vB development is that they'll never do something to help a third party mod which wouldn't be news to you either.

Re applying a code fudge after future upgrades is a pain to remember but at worst, it ends up like it is at the moment until I see the problem and patch again so that's not too bad a result.

[glennrocksvb]

Ok I think I know what's going on now. The PHP hook that is used to set the reported post into moderation queue that the mod is doing is vB's onAfterContentAddOrUpdate hook function which means the spam post has been saved already before vB triggered this hook. So at that point, vB has triggered the email notifications to the subscribers (as it normally does for a new post) before the mod is able to automatically disapprove the post.

To resolve this issue, vB should add a PHP hook right before it triggers the email to the subscribers to let third-party mods be able to cancel the email.

I will see if I can manually add a PHP hook as a temporary solution. If this is feasible, this would require editing existing PHP code which means this would have to be re-applied after every vB upgrade.

[ayjayef]

This bug became real today. Stop Links in Posts blocked a spammer (great!) put the message in a moderation queue and emailed all those subscribed to the area. One of our users followed the forum link in his email notification and got and error that he wasn't allowed to view (as expected as it's in the moderation queue). Contacted us to ask why he was blocked!