Stop Links in Posts

[ayjayef]

My experience of vB development is that they'll never do something to help a third party mod which wouldn't be news to you either.

Re applying a code fudge after future upgrades is a pain to remember but at worst, it ends up like it is at the moment until I see the problem and patch again so that's not too bad a result.

[glennrocksvb]

Ok I think I know what's going on now. The PHP hook that is used to set the reported post into moderation queue that the mod is doing is vB's onAfterContentAddOrUpdate hook function which means the spam post has been saved already before vB triggered this hook. So at that point, vB has triggered the email notifications to the subscribers (as it normally does for a new post) before the mod is able to automatically disapprove the post.

To resolve this issue, vB should add a PHP hook right before it triggers the email to the subscribers to let third-party mods be able to cancel the email.

I will see if I can manually add a PHP hook as a temporary solution. If this is feasible, this would require editing existing PHP code which means this would have to be re-applied after every vB upgrade.

[ayjayef]

This bug became real today. Stop Links in Posts blocked a spammer (great!) put the message in a moderation queue and emailed all those subscribed to the area. One of our users followed the forum link in his email notification and got and error that he wasn't allowed to view (as expected as it's in the moderation queue). Contacted us to ask why he was blocked!

[ayjayef]

Not really, if I disable the mod then the post won't be auto-moderated and the 2nd user would get an email anyway.

[glennrocksvb]

Now can you temporarily disable this mod and then try again? Just want to confirm it works without the mod.

[ayjayef]

Just created a new user and can confirm they received email notification with the the message and it appears in their message centre too... both with the link in a post that is waiting for moderation.

[glennrocksvb]

Can you test with a regular user subscriber on your site?

[ayjayef]

Good question, on my site the subscriber was an admin but on your site (this thread) I'm not an admin and it did the same.

[glennrocksvb]

Is the subscriber a regular user or a Moderator/Admin?

[ayjayef]

I bought the mod, simple install into vBull 5.6.6 and the mod works well on all our testing including the spammers sneaky color changed links, thanks!

I can confirm that if someone is subscribed to the thread or the sub-forum they will get email notification of a new post showing the moderated content which is not ideal. Hopefully we can workout how to stop that.

[glennrocksvb]

I'll test on my local setup to check if the issue also occurs there.

[ayjayef]

I'm not smart enough to know if it's vB or your addon but I'm sure you'll make sense of it.

I've not seen it happen on my site though.

[glennrocksvb]

I just posted a test from low post count account above with a link in it and it has correctly hid the post in a moderation queue.

...but, it emailed the subscription notification with the hidden spam link in it to everyone who is subscribed to this thread.

Bug?

That's a good catch. That looks like a bug. But even without this mod vB should not have emailed subscription notifications in the first place if a post is in moderated queue, right? That seems like a vB bug in itself. Other users should not see the moderated posts in the email.

[ayjayef]

I just posted a test from low post count account above with a link in it and it has correctly hid the post in a moderation queue.

...but, it emailed the subscription notification with the hidden spam link in it to everyone who is subscribed to this thread.

Bug?

[elektro-kot]

kether , ayjayef

Hi.
The first version of the module worked fine, there was one error (previously i reported a problem).

Recently, Glenn has released an update (version 1.1), everything works perfect now.