Visitors in the Last X Hours Module

[Tariq]

Glenn I like to know is there an upgrade for this mod. I believe I purchased this mod. Can you check please and if so can you send me an upgrade?

[flohse]

Hello Glenn,

can you please add an option to exclude invisible users from the list?

Thanks in advance.

[Snowhog]

If you are an Administrator; I'm assuming you are; you will see invisible users. Regular users will not.

[flohse]

I'd like to get phrase support for the module title. Is there any chance to see this in the near future?

Frank

[glennrocksvb]

flohse, not being able to translate Module title is not specific to this mod only. It's on all modules.

But starting in vB 6.1.2, vBulletin started support for using phrases in module titles. Please see the Translations section in their release notes linked below:

https://forum.vbulletin.com/forum/vbulletin-announcements/vbulletin-announcements_aa/4501908-vbulletin-6-1-2-release-notes

[flohse]

I know. I can change the phrases for other modules in the Sitebuilder but not for your specific module. So I think it has something to do with how this module handles phrases?

Frank

[flohse]

Hello Glenn,

I am having a strange issue with this mod. I have the following user accounts.:


The displaynames are shown fine everywhere in the forum except in the specific Last 24 Hours module.

Latest Topics for example is ok.



But the Visitors in the Last 24 Hours module shows garbled displaynames after the third name.



I have checked the database with phpMyAdmin. The data is correct. The admincp also shows the correct displaynames.



I hope, this is simply a display problem of this module and can easily be fixed.

Can you please help and advise what I can provide for further troubleshooting?

Thanks.

Frank

vBulletin 6.1.3
MySQL 8.0.43-0ubuntu0.24.04.1
PHP Version 8.3.6

[flohse]

Hello Glenn,

I think I have tracked down the cause for this issue to a code fragment in the template widget_vbmods_last_visitors.

The first block in the "if" statement seems to be causing the problem.

<vb:if condition="!empty($usergroups[$usergroupid])">

        <vb:if condition="!empty($usergroups[$usergroupid][0])">
                {vb:set displayUsername, {vb:raw usergroups.$usergroupid.0}}
                {vb:strcat displayUsername, {vb:raw username}}
                {vb:strcat displayUsername, {vb:raw usergroups.$usergroupid.1}}
        <vb:else />
                {vb:set displayUsername, {vb:raw username}}
        </vb:if>

<vb:else />

        {vb:data musername, user, fetchMusername, {vb:raw onlineUser}}
        <vb:if condition="$musername != $username">
                {vb:set displayUsername, {vb:raw musername}}
                {vb:set usernameTags, {vb:php explode, {vb:raw username}, {vb:raw musername}}}
                {vb:set usergroups.$usergroupid, {vb:raw usernameTags}}
        <vb:else />
                {vb:set displayUsername, {vb:raw username}}
                {vb:set usergroups.$usergroupid, {vb:php array, '', ''}}
        </vb:if>

</vb:if>
​

If you remove the first block everything is shown correctly.

Before removal:


After removal :


Can you please explain what the first block in the "if" statement is needed for and possibly fix this for the community? I don't want to break anything else.

Thanks in advance.

Frank

[glennrocksvb]

flohse, thanks for providing detailed and helpful information. I'll debug on my end and let you know.

[glennrocksvb]

flohse, please answer the following:

1. The affected users are all Registered Users, right?
2. Do Registered Users usergroup have Username HTML Markup configured in the Usergroup Manager? It looks like it doesn't but I want to confirm.
3. If you set the mod to only show usernames without avatars, does the same issue occur?

[glennrocksvb]

flohse, I couldn't reproduce the issue on my end. Please answer the following additional questions:

1. Try changing to a different style/theme. Does the issue still occur?
2. What is your vB and PHP versions?

[flohse]

Hello Glenn,

here is the requested information.

The affected users are all Registered Users, right?

No, Affected users have this setting:



I want the bots to show up as regular users. As far as I remember the bots need elevated privileges for the mods "Welcome Post for New Users" and "Auto-Create Flag Report Topic".

Do Registered Users usergroup have Username HTML Markup configured in the Usergroup Manager? It looks like it doesn't but I want to confirm.

No. They don't.



But Administrators have.

If you set the mod to only show usernames without avatars, does the same issue occur?

Yes.

Try changing to a different style/theme. Does the issue still occur?

It is the same with unmodified themes, i. e. "Gradient":



with only text:

What is your vB and PHP versions?

Already mentioned in post #172.

vBulletin 6.1.3
MySQL 8.0.43-0ubuntu0.24.04.1
PHP Version 8.3.6

Frank

[glennrocksvb]

Thanks for the detailed responses. Let me tray again on my end. I didn't have that odd Registered Users primary usergrop and Administrators secondary usergroup set up.

[glennrocksvb]

I want the bots to show up as regular users. As far as I remember the bots need elevated privileges for the mods "Welcome Post for New Users" and "Auto-Create Flag Report Topic".

Wait, adding Administrator as secondary usergroup to Registered Users usergroups grants all regular users (not just Bot users) with Administrative privileges that you set. That's dangerous! It's unrelated to the mod issue but I don't think you should do that.

[glennrocksvb]

flohse, let's debug in your forum. To prevent spamming other users here, please send me a PM and I will send you the code to temporarily add to the widget_vbmods_last_visitors template that will output debug messages on the page.