Announcement

Collapse
No announcement yet.

CKEditor Drag and Drop Image Upload

Collapse
This is a sticky topic.
X
X
Collapse
First Prev Next Last
 
  • Filter
  • Time
  • Show
Clear All
new posts

    #16

    Click image for larger version

Name:	IMG_1088.JPG
Views:	241
Size:	103.4 KB
ID:	6418

    Comment


    • glennrocksvb
      glennrocksvb commented
      Editing a comment
      Nice! Thanks for testing. What browser did you use? Just want to know the scope of the browser support.

    #17
    Ok yes that works.
    Tested in Chrome, IE and Firefox.
    Doesn't seem to work in Opera, not sure anyone cares about that though. Opera just ignores it.

    Comment


    • glennrocksvb
      glennrocksvb commented
      Editing a comment
      Our posts crossed. May I know the Opera version? It's Webkit-based now and supposed to be like Chrome.

    • Mark.B
      Mark.B commented
      Editing a comment
      It's working now Glenn...I did a cache clear and it was fine after that.
      I keep forgetting Opera's cache is a bit...aggressive...at times.
      Opera 47.0.2631.80 (PGO) though, for the record.

    • glennrocksvb
      glennrocksvb commented
      Editing a comment
      Cool, thanks for checking!

    #18
    lets try opera
    Click image for larger version  Name:	elv.png Views:	1 Size:	58.6 KB ID:	6427This was done in opera



    will try in tor next
    Last edited by willie53; 09-22-2017, 03:29 PM. Reason: overlapped post
    Wise men say nothing Fools never listen

    Comment


      #19
      And this one is tor
      Click image for larger version

Name:	test.gif
Views:	138
Size:	44.2 KB
ID:	6429
      Wise men say nothing Fools never listen

      Comment


        #20
        Thank you all guys for testing in different browsers. I'm confident now this mod works in all modern browsers.
        Helpful? Donate. Thanks!
        Buy me a coffeePayPal QR Code
        Fast VPS Host for vBulletin:
        A2 Hosting & IONOS

        Comment


        • willie53
          willie53 commented
          Editing a comment
          just hope it is compatible with vb5.3.3

        • glennrocksvb
          glennrocksvb commented
          Editing a comment
          Afaik, there are no ckeditor changes in a while. But I will test to make sure.

        • glennrocksvb
          glennrocksvb commented
          Editing a comment
          Did a test 5.3.3 upgrade and tested this mod and it still works as expected.

        #21
        Cool
        Wise men say nothing Fools never listen

        Comment


          #22
          FYI, this mod is now released. Check it out in the first post.
          Helpful? Donate. Thanks!
          Buy me a coffeePayPal QR Code
          Fast VPS Host for vBulletin:
          A2 Hosting & IONOS

          Comment


            #23
            I bought this one but having some difficulty getting it to work but will plod on done all file edits
            Wise men say nothing Fools never listen

            Comment


            • glennrocksvb
              glennrocksvb commented
              Editing a comment
              Are the instructions difficult or confusing to follow?

            #24
            ckeditor-rollup difficult the line keeps spltting but i will get there
            Wise men say nothing Fools never listen

            Comment


              #25
              now getting error
              rClick image for larger version

Name:	error.png
Views:	91
Size:	7.5 KB
ID:	6460
              Wise men say nothing Fools never listen

              Comment


              • glennrocksvb
                glennrocksvb commented
                Editing a comment
                Check the browser dev tools console. You might have a JS error as a result of editing the ckeditor js. Make sure you didn't introduce a JS syntax error. Double-check your edits. Make sure the placement of commas are in the correct spots.

              #26
              almost there getting green box with file upload success but directly following this i get
              Click image for larger version

Name:	http.png
Views:	432
Size:	2.4 KB
ID:	6467
              Wise men say nothing Fools never listen

              Comment


              • glennrocksvb
                glennrocksvb commented
                Editing a comment
                Double check the PHP changes. Make sure there are no syntax errors. Enable debug mode to see the detailed error in dev tools Network tab.

              #27
              Got it sorted
              The problem was the way the edits were parsed as seen below
              Code:
              [COLOR=#006400]// the image inserts (<img> element in the editor body & hidden inputs in the[/COLOR]
              [COLOR=#FF0000]form) are handled as part of closeFileDialog() (normally would be handled by
              the onOk handler of the dialog)
              echo "window.parent.vBulletin.ckeditor.closeFileDialog('$editorId', " .
              json_encode($info) . ");";[/COLOR]
              Green commented out
              Red not commented out
              Just commented all out and that sorted it
              Wise men say nothing Fools never listen

              Comment


              • glennrocksvb
                glennrocksvb commented
                Editing a comment
                Glad you sorted it out. Those comments should be in one line. Are they not in one line in the readme? They may wrap with soft line breaks due to space limitation but when copy pasted in the editor, it shouldn't insert hard line breaks when the line wraps.

              #28
              They are not on one line i think that is the way adobe inserts wrap around as seen below
              Click image for larger version

Name:	wrap.png
Views:	102
Size:	29.0 KB
ID:	6478
              Wise men say nothing Fools never listen

              Comment


              • glennrocksvb
                glennrocksvb commented
                Editing a comment
                Ok, I checked and confirmed Adobe messed up the linebreaks. I will replace the readme.pdf with a different file format. Thanks for reporting this.

              #29
              Click image for larger version  Name:	IMG_0889.png Views:	1 Size:	643.7 KB ID:	6480
              Last edited by glennrocksvb; 10-03-2017, 08:11 AM. Reason: Resized image too big

              Comment


                #30
                I have replaced the readme file with HTML format. I confirmed that copying and pasting the code now preserves the correct linebreaks. Buyers of this mod have been emailed with the new download link.

                Thanks willie53 for reporting this issue.
                Helpful? Donate. Thanks!
                Buy me a coffeePayPal QR Code
                Fast VPS Host for vBulletin:
                A2 Hosting & IONOS

                Comment

                Users Viewing This Page

                Collapse

                There is 1 user viewing this forum topic.

                • Guest Guest

                Latest Posts

                Collapse

                Working...
                X
                Searching...Please wait.
                An unexpected error was returned: 'Your submission could not be processed because you have logged in since the previous page was loaded.

                Please push the back button and reload the previous window.'
                An unexpected error was returned: 'Your submission could not be processed because the token has expired.

                Please push the back button and reload the previous window.'
                An internal error has occurred and the module cannot be displayed.
                There are no results that meet this criteria.
                Search Result for "|||"